Skip to content

Add Phase-2 TBV testnet documentation#443

Open
web3jenks wants to merge 4 commits into
mainfrom
feat/testnet-docs-restructure-phase-2-ready
Open

Add Phase-2 TBV testnet documentation#443
web3jenks wants to merge 4 commits into
mainfrom
feat/testnet-docs-restructure-phase-2-ready

Conversation

@web3jenks

Copy link
Copy Markdown
Collaborator

Summary

  • Add Phase-2 TBV testnet documentation: Safety & trust assumptions and the Technical Details section.
  • Add Confluence-matched diagrams for the new Phase-2 pages.
  • Remove Phase-1 redirects that would otherwise hide the newly published Phase-2 pages.

Confluence alignment

  • Synced against the TBV Testnet Documentation Draft tree.
  • Excluded skipped/unpublishable Confluence pages, including the skipped TBV fees page and placeholder-heavy security/whitepaper pages.
  • Built on top of the borrowing wording update so the Phase-2 branch matches the current user-facing terminology.

Validation

  • ALGOLIA_APP_ID=local ALGOLIA_API_KEY_READONLY=local npm run build
  • Known existing warnings remain: remote release/v3.x staking-script fetch 404, Docusaurus markdown config deprecation, stale Browserslist data, and existing top-level redirect warnings for /stakers, /developers, /operators.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🔐 Commit Signature Verification

All 4 commit(s) passed verification

Commit Author Signature Key Type Key Check
3bc4c04179be Jenks sk-ssh-ed25519
1dbcf37fc8fe Jenks sk-ssh-ed25519
d72803c44ef7 Jenks sk-ssh-ed25519
42bc9cb2766d Jenks sk-ssh-ed25519

Summary

  • Commits verified: 4
  • Signature check: ✅ All passed
  • Key type enforcement: ✅ All sk-ssh-ed25519

Required key type: sk-ssh-ed25519 (FIDO2 hardware key)

Last verified: 2026-06-19 03:33 UTC

@greptile-apps

greptile-apps Bot commented Jun 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR publishes Phase-2 TBV testnet documentation. The main changes are:

  • New Safety & trust assumptions page.
  • New Technical Details section for architecture, actors, and Aave v4 integration.
  • Updated TBV terminology from lending dashboard to Testnet app and borrowing position.
  • Removed redirects that previously hid Phase-2 TBV routes.
  • Added two Confluence-matched diagram images.

Confidence Score: 4/5

This is close, but the self-challenge docs should be fixed before merging.

  • The new trust model pages give conflicting instructions about whether depositors can broadcast fraud challenges.
  • The new Phase-2 pages are not added to the manual TBV sidebar, so they are hard to discover from navigation.
  • One architecture step mixes the Pre-PegIn refund path with active vault redemption.

sidebars-default.js, docs/trustless-bitcoin-vault/technical-details/protocol-actors.mdx, and docs/trustless-bitcoin-vault/technical-details/protocol-architecture.mdx.

Important Files Changed

Filename Overview
sidebars-default.js The manual TBV sidebar was not updated for the newly published pages or the borrowing label.
docs/trustless-bitcoin-vault/technical-details/protocol-actors.mdx The new actor documentation contradicts itself on who can broadcast fraud challenges.
docs/trustless-bitcoin-vault/technical-details/protocol-architecture.mdx The new architecture page mostly documents lifecycle flow, but one peg-out step mixes refund and redemption paths.

Reviews (1): Last reviewed commit: "docs(tbv): add phase 2 testnet documenta..." | Re-trigger Greptile

Comment thread docs/trustless-bitcoin-vault/technical-details/protocol-actors.mdx Outdated
Comment thread docs/trustless-bitcoin-vault/technical-details/protocol-architecture.mdx Outdated
Comment thread docs/trustless-bitcoin-vault/use-for-lending/_category_.json
Comment thread docs/trustless-bitcoin-vault/technical-details/_category_.json
web3jenks and others added 2 commits June 19, 2026 10:00
…re sidebar

Updates the three Technical Details pages to the current Confluence content
(Protocol architecture, Protocol actors, Aave v4 integration), and adds the
missing "Technical Details" category to the TBV sidebar so the pages are
reachable.

Content refresh (from the latest Confluence source):
- protocol-architecture: split the Ethereum layer into protocol contracts
  vs per-application integration contracts; clarified that the Bitcoin and
  Ethereum protocol layers are shared design and applications add their own
  adapters via the application registry.
- protocol-actors: restructured around the Vault Keeper umbrella (Vault
  Provider, Application Vault Keeper, Universal Challenger) plus the
  transitional Security Council; AVK arbitrage framed as Aave-specific.
- aave-v4-integration: vaultBTC framed as the adapter's internal accounting
  token; partial vs full-position liquidation and the fairness mechanism
  clarified.

Sidebar: new "Technical Details" category inserted between "Use TBV Testnet
For Lending" and "Research" in sidebars-default.js (the pages existed but
were not wired into any sidebar).

Diagram unchanged (already committed at full resolution). All relative
cross-links verified to resolve; built locally with all three routes
returning 200 and no broken-link warnings.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… page

Resolves the four Greptile findings on PR #443:

- P1 (protocol-actors): reconcile challenge permissioning — distinguish
  protocol-wide challenging (requires a registered Universal Challenger)
  from own-vault challenging (any depositor, no registration, using the
  BABE artifacts + keys committed in that vault's Taproot tree at peg-in).
- P2 (protocol-architecture): stop listing the Pre-PegIn refund as a
  vault-output Claim leaf; the Claim spends a redemption leaf (repayment
  or liquidation), refund is a separate Pre-PegIn output/path.
- P2 (sidebar label): align the manual sidebar label to the category
  metadata — "Use TBV Testnet For Borrowing".
- P2 (orphaned pages): add the Safety & trust assumptions page to the
  Start Here sidebar (Technical Details was wired in the previous commit)
  so all Phase-2 pages are discoverable from the nav.

Verified with a full production build (onBrokenLinks: 'throw'): build
succeeds, zero broken links across the site.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@web3jenks web3jenks requested a review from kkkk666 June 19, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant